-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
82281f2
to
b3752d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks fine... I agree with @ANeumann82 points since he has a reject on it I'll assume it's all good after that is resolved... I'm good without the changes as well... the changes seems useful but not critical
@@ -0,0 +1,111 @@ | |||
package authentication | |||
|
|||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like it could be a kuttl test which might be easier to read and consume
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great!
I have two suggestions:
- not using env variables to populate the password. If we can use a filebased approach that would be slightly better.
- add authentication credentials also to
cqlshrc
file, otherwisecqlsh
queries will fail.
cqlshrc
can be part of another PR but I feel we should avoid passwords living in env variables. WDYT?
Passwords in env variables are fine as long as they're not exported. But you raise a good point here, because passwords as part of a command line are not fine because they can be extracted by a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There's no good way to fully secure |
Calls by the operator to
nodetool
are authenticated with credentials provided as a secret by the admin.